From 7530772acde22a3f440b4d0b4e0bc527a5acd1c9 Mon Sep 17 00:00:00 2001
From: Ashley Strahle <ash@jackofclubs.com.au>
Date: Wed, 1 Jul 2026 04:18:00 +0000
Subject: [PATCH] add adv->setName, remove diagnostics and ext adv flag; revert
 to stable

---
 platformio.ini             |  1 -
 src/ble_midi_transport.cpp | 13 +------------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/platformio.ini b/platformio.ini
index 41477e8..f21db17 100644
--- a/platformio.ini
+++ b/platformio.ini
@@ -18,7 +18,6 @@ build_flags =
     -DARDUINO_USB_CDC_ON_BOOT=1
     -DUSE_TINYUSB=1
     -Wno-macro-redefined
-    -DMYNEWT_VAL_BLE_EXT_ADV=0
 
 monitor_speed = 115200
 
diff --git a/src/ble_midi_transport.cpp b/src/ble_midi_transport.cpp
index 3bb262f..cd6559c 100644
--- a/src/ble_midi_transport.cpp
+++ b/src/ble_midi_transport.cpp
@@ -48,18 +48,12 @@ bool BleMidiTransport::begin() {
     NimBLEDevice::init("JOC Midi");
     Serial.println("[BLE] NimBLEDevice initialized");
 
-    esp_bt_controller_status_t ctl = esp_bt_controller_get_status();
-    Serial.printf("[BLE] Controller status: %d (0=IDLE 1=INITED 2=ENABLED)\n", ctl);
-
     Serial.println("[BLE] Creating server...");
     ble_server = NimBLEDevice::createServer();
     if (!ble_server) {
         Serial.println("[BLE] FAILED to create server");
         return false;
     }
-    NimBLEAddress addr = NimBLEDevice::getAddress();
-    Serial.printf("[BLE] Address: %s\n", addr.toString().c_str());
-
     Serial.println("[BLE] Server created, setting callbacks...");
     ble_server->setCallbacks(new ServerCallbacks());
 
@@ -95,16 +89,11 @@ bool BleMidiTransport::begin() {
 
     Serial.println("[BLE] Starting advertising...");
     NimBLEAdvertising* adv = NimBLEDevice::getAdvertising();
+    adv->setName("JOC Midi");
     adv->addServiceUUID(BLE_MIDI_SERVICE_UUID);
     adv->setScanResponse(true);
     adv->start();
 
-    if (adv->isAdvertising()) {
-        Serial.println("[BLE] Advertising confirmed started");
-    } else {
-        Serial.println("[BLE] WARNING: isAdvertising() reports false!");
-    }
-
     initialized = true;
     Serial.println("[BLE] BLE MIDI advertising as 'JOC Midi'");
     return true;