From d8c109d9e572cfddb26f9b9bb9d5dc30005a6bee Mon Sep 17 00:00:00 2001
From: Ashley Strahle <ash@jackofclubs.com.au>
Date: Tue, 30 Jun 2026 13:14:19 +0000
Subject: [PATCH] remove setName and health check (caused crashes), add
 isAdvertising() check

---
 src/ble_midi_transport.cpp | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/ble_midi_transport.cpp b/src/ble_midi_transport.cpp
index f5bbbee..f6112b2 100644
--- a/src/ble_midi_transport.cpp
+++ b/src/ble_midi_transport.cpp
@@ -95,9 +95,14 @@ bool BleMidiTransport::begin() {
     NimBLEAdvertising* adv = NimBLEDevice::getAdvertising();
     adv->addServiceUUID(BLE_MIDI_SERVICE_UUID);
     adv->setScanResponse(true);
-    adv->setName("JOC Midi");
     adv->start();
 
+    if (adv->isAdvertising()) {
+        Serial.println("[BLE] Advertising confirmed started");
+    } else {
+        Serial.println("[BLE] WARNING: isAdvertising() reports false!");
+    }
+
     initialized = true;
     Serial.println("[BLE] BLE MIDI advertising as 'JOC Midi'");
     return true;
@@ -105,15 +110,6 @@ bool BleMidiTransport::begin() {
 
 void BleMidiTransport::update() {
     client_connected = device_connected;
-    static unsigned long last_health = 0;
-    if (millis() - last_health > 30000) {
-        last_health = millis();
-        NimBLEAdvertising* adv = NimBLEDevice::getAdvertising();
-        if (adv && !adv->isAdvertising()) {
-            Serial.println("[BLE] Restarting advertising...");
-            adv->start();
-        }
-    }
 }
 
 void BleMidiTransport::on_midi_receive(std::function<void(const MidiEvent&)> callback) {