From f0b6df14770d8055558334dbd5f8d536d448ff5f Mon Sep 17 00:00:00 2001
From: Ashley Strahle <ash@jackofclubs.com.au>
Date: Thu, 2 Jul 2026 04:14:39 +0000
Subject: [PATCH] Remove serial cal commands, just log raw ADC on each value
 change

- Print raw ADC + mapped MIDI value on every change
- Remove cal min/cal max serial commands (broken with multi-word)
- Keep cal_min=0, cal_max=4095 defaults
- User moves pedal full range and reports min/max raw values
---
 src/expression_pedal.cpp |  9 ++++-----
 src/main.cpp             | 13 +++----------
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/src/expression_pedal.cpp b/src/expression_pedal.cpp
index 68fb726..5feceac 100644
--- a/src/expression_pedal.cpp
+++ b/src/expression_pedal.cpp
@@ -21,12 +21,11 @@ void ExpressionPedal::begin() {
     pinMode(adc_pin, INPUT);
     delay(10);
     current_raw = analogRead(adc_pin);
-    cal_min = current_raw;
     current_value = adc_to_midi(current_raw);
     last_sent_value = current_value;
-    Serial.printf("[EXP] Calibrating... press toe then type 'cal max'\n");
-    Serial.printf("[EXP] Current ADC: %d -> MIDI: %d\n", current_raw, current_value);
-    Serial.printf("[EXP] cal_min=%d cal_max=%d (default)\n", cal_min, cal_max);
+    Serial.printf("[EXP] Starting: raw ADC=%d -> MIDI=%d (cal: %d-%d)\n",
+                  current_raw, current_value, cal_min, cal_max);
+    Serial.printf("[EXP] Move pedal full range to see raw values\n");
 }
 
 void ExpressionPedal::update(UsbMidiTransport& midi) {
@@ -46,7 +45,7 @@ void ExpressionPedal::update(UsbMidiTransport& midi) {
     if (current_value != last_sent_value) {
         last_sent_value = current_value;
         midi.send_cc(midi_channel, midi_cc, current_value);
-        Serial.printf("[EXP] CC%d: %d\n", midi_cc, current_value);
+        Serial.printf("[EXP] CC%d: %d (raw ADC: %d)\n", midi_cc, current_value, current_raw);
     }
 }
 
diff --git a/src/main.cpp b/src/main.cpp
index c374843..7608fc3 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -87,13 +87,8 @@ void handle_serial_command(const String& cmd) {
         mux.show();
         Serial.println("[CMD] Pixel 1 WHITE (max brightness)");
     } else if (cmd == "exp") {
-        Serial.printf("[CMD] EXP ADC=%d MIDI=%d cal_min=%d cal_max=%d\n",
-                      exp_pedal.get_raw(), exp_pedal.get_value(),
-                      exp_pedal.get_cal_min(), exp_pedal.get_cal_max());
-    } else if (cmd == "cal min") {
-        exp_pedal.set_cal_min();
-    } else if (cmd == "cal max") {
-        exp_pedal.set_cal_max();
+        Serial.printf("[CMD] EXP ADC=%d MIDI=%d\n",
+                      exp_pedal.get_raw(), exp_pedal.get_value());
     } else if (cmd == "usb") {
         Serial.printf("[CMD] USB mounted: %s\n", TinyUSBDevice.mounted() ? "YES" : "NO");
         Serial.printf("[CMD] USB ready: %s\n", TinyUSBDevice.ready() ? "YES" : "NO");
@@ -137,9 +132,7 @@ void handle_serial_command(const String& cmd) {
         Serial.println("  read       - raw button read");
         Serial.println("  red/green/blue - solid colour");
         Serial.println("  pixel0/pixel1 - single pixel test");
-        Serial.println("  exp        - expression pedal ADC/MIDI/cal values");
-        Serial.println("  cal min    - set current pedal position as minimum (heel)");
-        Serial.println("  cal max    - set current pedal position as maximum (toe)");
+        Serial.println("  exp        - expression pedal ADC/MIDI value");
         Serial.println("  usb        - USB connection status and descriptor info");
         Serial.println("  gpiotest   - raw GPIO pin diagnostic");
         Serial.println("  rawled     - bit-bang WS2812 (no library)");